#50085 Issue 50037 - lib389 fails to install in venv under non-root user
Closed by spichugi. Opened by vashirov.
vashirov/389-ds-base 50037  into  master

Download 50085.patch

Bug description:
Some files were installed using absolute path, preventing installation
under non-root user.

Fix description:
Change paths to be relative to the current prefix.
Update .gitignore to exlcude venv.
Update tox.ini to the current supported Python versions.

https://pagure.io/389-ds-base/issue/50037

Reviewed by: ???

If that would be beneficial for venv installation, could we simply install using scripts and move the files into /usr/sbin after running setup.py (probably both in Makefile.am and the SPEC file).

Anyway, building from SPEC file does not work for me as manpages are now installed into /usr/man/man8 instead of /usr/share/man/man8 (%{_mandir} macro in SPEC file expands to /usr/share/man).

I mean, we should probably respect the way of setup.py and post-adjust as required.

rebased onto 964eacfa112acb5647d762c76647d078904a2888

I've adjusted setup.py to fix rpm build.

This looks good to me, but I have not run rpm build.

Is it still relevant? Could you please rebase so we can test it and probably merge?

rebased onto c4a2eb4a61fe381e842e45b8a3a89a225b42ff28

@spichugi, yes it's still relevant. I've updated the patch.

LGTM! Ack

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3144

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata