PR#50085: Issue 50037 - lib389 fails to install in venv under non-root user - 389-ds-base

389-ds-base

#50085 Issue 50037 - lib389 fails to install in venv under non-root user

Closed 3 years ago by spichugi. Opened 5 years ago by vashirov.

vashirov/389-ds-base 50037 into master

Issue 50037 - lib389 fails to install in venv under non-root user

Viktor Ashirov • 4 years ago

c4a2eb4

.gitignore

file modified

		`@@ -225,3 +225,8 @@`
		`src/lib389/dist/`
		`src/lib389/man/`
		`src/libsds/target/`
		`+ dist`
		`+ venv`
		`+ .idea`
		`+ src/cockpit/389-console/cockpit_dist/`
		`+ src/cockpit/389-console/node_modules/`

src/lib389/setup.py

file modified

+3 -3

		`@@ -46,9 +46,9 @@`
		`'Intended Audience :: Developers',`
		`'Operating System :: POSIX :: Linux',`
		`'Programming Language :: Python :: 3',`
		`- 'Programming Language :: Python :: 3.4',`
		`'Programming Language :: Python :: 3.5',`
		`'Programming Language :: Python :: 3.6',`
		`+ 'Programming Language :: Python :: 3.7',`
		`'Topic :: Software Development :: Libraries',`
		`'Topic :: Software Development :: Quality Assurance',`
		`'Topic :: Software Development :: Testing'],`
		`@@ -58,14 +58,14 @@`

		`# find lib389/clitools -name ds\* -exec echo \''{}'\', \;`
		`data_files=[`
		`- ('/usr/sbin/', [`
		`+ ('sbin/', [`
		`'cli/dsctl',`
		`'cli/dsconf',`
		`'cli/dscreate',`
		`'cli/dsidm',`
		`'cli/dscontainer',`
		`]),`
		`- ('/usr/share/man/man8', [`
		`+ ('share/man/man8', [`
		`'man/dsctl.8',`
		`'man/dsconf.8',`
		`'man/dscreate.8',`

src/lib389/tox.ini

file modified

+1 -1

		`@@ -1,5 +1,5 @@`
		`[tox]`
		`- envlist = py27, py34, py35, py36`
		`+ envlist = py35, py36, py37`

		`[testenv]`
		`deps = -rrequirements.txt`

vashirov commented 5 years ago

Bug description:
Some files were installed using absolute path, preventing installation
under non-root user.

Fix description:
Change paths to be relative to the current prefix.
Update .gitignore to exlcude venv.
Update tox.ini to the current supported Python versions.

https://pagure.io/389-ds-base/issue/50037

Reviewed by: ???

mhonek commented 5 years ago

If that would be beneficial for venv installation, could we simply install using scripts and move the files into /usr/sbin after running setup.py (probably both in Makefile.am and the SPEC file).

Anyway, building from SPEC file does not work for me as manpages are now installed into /usr/man/man8 instead of /usr/share/man/man8 (%{_mandir} macro in SPEC file expands to /usr/share/man).

I mean, we should probably respect the way of setup.py and post-adjust as required.

rebased onto 964eacfa112acb5647d762c76647d078904a2888

5 years ago

vashirov commented 5 years ago

I've adjusted setup.py to fix rpm build.