389-ds-base

Clone
Source Code
GIT

#50072 Ticket 49864 - Revised replication status messages for transient errors
Closed 3 years ago by spichugi. Opened 5 years ago by mreynolds.
mreynolds/389-ds-base ticket49864  into  master

file modified
+1 -1 
@@ -1065,7 +1065,7 @@ 
 

                      } else if (rc == UPDATE_TRANSIENT_ERROR) {
 

                          dev_debug("repl5_inc_run(STATE_SENDING_UPDATES) -> send_updates = UPDATE_TRANSIENT_ERROR -> STATE_BACKOFF_START");
 

                          agmt_set_last_update_status(prp->agmt, 0, NSDS50_REPL_TRANSIENT_ERROR,
 

-                                                     "Incremental update transient error.  Backing off, will retry update later.");
 

+                                                     "Incremental update transient warning.  Backing off, will retry update later.");
 

                          next_state = STATE_BACKOFF_START;
 

                      } else if (rc == UPDATE_FATAL_ERROR) {
 

                          dev_debug("repl5_inc_run(STATE_SENDING_UPDATES) -> send_updates = UPDATE_FATAL_ERROR -> STATE_STOP_FATAL_ERROR");

file modified
+1 -1 
@@ -662,7 +662,7 @@ 
 

      case NSDS50_REPL_CONN_TIMEOUT:
 

          return "connection timeout";
 

      case NSDS50_REPL_TRANSIENT_ERROR:
 

-         return "transient error";
 

+         return "transient warning";
 

      case NSDS50_REPL_RUV_ERROR:
 

          return "RUV error";
 

      default:

Description:

Transient errors are temporary conditions that usually resolve
themselves. But the message are vague and alarming. This
patch changes it to a "warning" message.

https://pagure.io/389-ds-base/issue/49864

LGTM

Ack, what log level is this emitted at? does that need to be tweaked also? Or is this just in nsds50replstatus (I think it is ....)

Ack, what log level is this emitted at? does that need to be tweaked also? Or is this just in nsds50replstatus (I think it is ....)

This is just in the agmt status attribute: nsds5replicaLastUpdateStatus

rebased onto bb335e0
5 years ago

Pull-Request has been merged by mreynolds
5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3131

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
3 years ago
Metadata
None
No Tags
Changes Summary 2
+1 -1
file changed
ldap/servers/plugins/replication/repl5_inc_protocol.c
+1 -1
file changed
ldap/servers/plugins/replication/repl5_protocol_util.c
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.