PR#50058: Pass argument into hashtable_new - 389-ds-base

389-ds-base

#50058 Pass argument into hashtable_new

Closed 3 years ago by spichugi. Opened 5 years ago by slev.

slev/389-ds-base fix_uninit_usetxn into 389-ds-base-1.3.9

Pass argument into hashtable_new

Stanislav Levin • 5 years ago

851fcf8

ldap/servers/plugins/memberof/memberof.h

file modified

+1 -1

		`@@ -102,7 +102,7 @@`
		`void memberof_release_config(void);`
		`PRUint64 get_plugin_started(void);`
		`void ancestor_hashtable_entry_free(memberof_cached_value *entry);`
		`- PLHashTable *hashtable_new();`
		`+ PLHashTable *hashtable_new(int usetxn);`
		`int memberof_use_txn();`

		`#endif /* _MEMBEROF_H_ */`

ldap/servers/plugins/memberof/memberof_config.c

file modified

+2 -2

		`@@ -698,8 +698,8 @@`

		`/* Allocate our caches here since we only copy the config at the start of an op */`
		`if (memberof_use_txn() == 1){`
		`- dest->ancestors_cache = hashtable_new();`
		`- dest->fixup_cache = hashtable_new();`
		`+ dest->ancestors_cache = hashtable_new(1);`
		`+ dest->fixup_cache = hashtable_new(1);`
		`}`

		`/* Check if the copy is already up to date */`

slev commented 5 years ago

@8915d8d87 and @4471b7350 modified "usetxn" parameter in
"hashtable_new" scope (was a global variable before).
But the callers of this function don't pass an argument into.
Thus, "usetxn" acts like an uninitialized auto variable.

Originally made for 1.3.9, but can be imported to 1.4.x.

Fixes: https://pagure.io/389-ds-base/issue/50057