Couple of small issue:

• When we click on 'repl-config-save' button and some of the Advanced Settings is changed - nothing happens. No loading, no actual change in the DS.

• If I create an agreement 'to_inst2' on instance1 and then I switch to instance2, I see 'to_inst2' agreement in the instance2 table.
  And then if I add a new agreement 'to_inst1' on instance2, then 'to_inst2' agreement row disappears and only 'to_inst1' is left. (which is right)

• At the same time:
  Last Init Status shows Not initialized
  but Last Update Status shows Enabled Error (0) Replica acquired successfully: Incremental update succeeded

• CleanAllRUV Tasks don't appear in the list after you created them (they appear only if they succeed right in the moment you created them). So there is no way to abort the task that is hanging for some time.
  It gives an error in the pop-up window after some time.

Couple of small issue:

When we click on 'repl-config-save' button and some of the Advanced Settings is changed - nothing happens. No loading, no actual change in the DS.

Works for me

If I create an agreement 'to_inst2' on instance1 and then I switch to instance2, I see 'to_inst2' agreement in the instance2 table.

I just fixed this...

And then if I add a new agreement 'to_inst1' on instance2, then 'to_inst2' agreement row disappears and only 'to_inst1' is left. (which is right)

At the same time:
Last Init Status shows Not initialized
but Last Update Status shows Enabled Error (0) Replica acquired successfully: Incremental update succeeded

You have to give me steps to reproduce this as I do not see this behavior.

CleanAllRUV Tasks don't appear in the list after you created them (they appear only if they succeed right in the moment you created them). So there is no way to abort the task that is hanging for some time.

Hmmm this does work correctly for me - no errors

Well I rebased the PR with a few fixes - please try again...

Couple of small issue:
When we click on 'repl-config-save' button and some of the Advanced Settings is changed - nothing happens. No loading, no actual change in the DS.

As discussed on IRC, Replication Connection Timeout - doesn't work. But some of them work.

And then if I add a new agreement 'to_inst1' on instance2, then 'to_inst2' agreement row disappears and only 'to_inst1' is left. (which is right)
At the same time:
Last Init Status shows Not initialized
but Last Update Status shows Enabled Error (0) Replica acquired successfully: Incremental update succeeded

You have to give me steps to reproduce this as I do not see this behavior.

Okay, I narrowed it down a bit.
First, while creating an agreement you choose 'Do Online Initialization'. So after the creation and initialization Last Init Status still shows Not initialized

CleanAllRUV Tasks don't appear in the list after you created them (they appear only if they succeed right in the moment you created them). So there is no way to abort the task that is hanging for some time.

Hmmm this does work correctly for me - no errors

Now it works correctly for me either... Maybe you fixed it, maybe the reproduction steps should be more complex...

Okay this is ready for review. The replication enabling/disabling has been vastly improved, and the handling of replication managers has been made more robust and simple.

Great!
Just a couple of issues...

• Replication Connection Timeout field is not updated once again...
• There is a weird case with updating Advanced settings on the Configuration tab. Reproduction steps:
• Install two clean instances
• Enable replication on one of them and set some Advanced settings there (i.e. Replication Protocol Timeout = 2)
• Switch to the second instance and enable replication there

Result: Replication Protocol Timeout will have value '2' (but it is only in UI for now). It shouldn't be there...

Actually, the same happens for the Agreements too.
1. Install two clean instances
2. Enable replication on one of them and add a replica agreement.
3. Switch to the second instance and enable replication there.

Result: we see the first agreement on the second instance. After we add any other agreement, the list is updated and we see only the right agreement.

It is possible, that the same thing will happen for other stuff like WinSync agreements.

Great!
Just a couple of issues...

Replication Connection Timeout field is not updated once again...

This is odd because I completely removed that field from the UI :-D So how are you seeing it?

I am not reproducing any of the problems you are running into. I really think you did not apply the current patch from this PR

Okay, it is true... I was using the command:

git fetch https://pagure.io/389-ds-base.git refs/pull/49983/head:pr49983

And I didn't reset my repo properly.

You have my ack. Let's merge it :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3042

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.