Missing ')' in the end

MIssing coma after 'do_winsync_agmt_init'

The rest looks good. :)

And what do you think regarding @mhonek comment? I think it makes sence to have a switch for the logging.
https://pagure.io/389-ds-base/issue/49978#comment-536490

The rest looks good. :)
And what do you think regarding @mhonek comment? I think it makes sence to have a switch for the logging.
https://pagure.io/389-ds-base/issue/49978#comment-536490

There's no overhead in having the logging, and I added a check for the presence of console.log() in log_cmd(). So it will be safe for obscure browsers that we technically would NOT support anyway ;-) We only support Firefox, Chrome, and MS Edge - all of which support console.log().

So I prefer to keep it "always on" and not add a hidden checkbox in the UI somewhere. I'll get the rest of the changes applied shortly

Please review :-)

Missing coma after 'do_agmt_init'...

okay, ack :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3041

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.