#49976 Ticket 49926 - Add replication functionality to UI
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket49926  into  master

Download 49976.patch

Description:

Add replication functionality to UI.

Cleaned up various UI interactions and page loading

Added console logging for all CLI commands

https://pagure.io/389-ds-base/issue/49926

Reviewed by: ?

rebased onto f286478110659aac2719af884ff219e7acf66c2f

Local development testing :)

insts are not defined here

valid_num is not defined too

If I put insts there and uncomment valid_num and valid_dn functions, the web page is not loaded when we don't have any instances.

As proposed by Mark (and I agree with him), we can merge it so it will get into next build but we should fix the minor issues first because it stops UI from loading when a user doesn't have any instances.

The rest can be fixed in the following PR. I will put more comments later after the detailed review.

I think it can be done as a one instruction:

agmt_name = agmt_name[1:-1]

We have from lib389.tasks import CleanAllRUVTask which is DSLdapObject for "cn=cleanallruv, cn=tasks, cn=config".
I think it is better to use it here instead of constructing naked DSLdapObjects only for list().
You can add 'list' method to tasks.py to Task(DSLdapObject). So we can list the active tasks in the future for any Task object instance.

It's defined in ds.js, am I missing something?

Looks like it is commented out (at least I see it like this, maybe bad rebase)

Where do you see it commented out? What file/line?

Okay, it is my mistake. I commented it out accidently with '/*' while changing back to 'var DSCONF = "dsconf"'... Sorry

rebased onto cf68341c154f88f043fa0f73a42035b480bfe4d4

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3035

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata