The adding tests requires this issue to be fixed - https://pagure.io/389-ds-base/issue/49911
It can be added without it but it will be full of unnecessary 'hacks'.

I want this PR to be merged this week before my PTO (if it will be possible, please, do not rush with the review).

I will add some basic tests in a meanwhile if everything will go okay. But the working WebUI and CLI come first.

Can this be removed ^^^

This should be "objectclass" not "attribute"

Editing a stand objectclass (alias) fails:

Failed to save the objectClass
Error: {'desc': 'Server is unwilling to perform', 'info': 'object class alias: Cannot delete a standard object class'}

The old java console blocked editing of standard schema - we should see if its easy to do the same in the new UI. It could also wait for a second PR as its not needed, the current error is sufficient I guess, but we could handle it better.

[1] Also when editing "a6Record " attribute, all the matching rule dropdown lists have two blank items at the top. That should be cleaned up.

[2] Editing standard attribute also errors out:

Failed to save the attribute
Error: {'desc': 'Server is unwilling to perform', 'info': 'attribute type a6record: Cannot delete a standard attribute type'}

[3] Create attribute, we list the syntax OIDs, but we should also list the syntax name. Something like:

• Directory String (1.2.1.1.23.2.1.32..2.212)

[4] Create attribute - syntax is required, but the UI does not enforce it. Then we get a ugly error from dsconf in the UI

[5] Edit Attribute (attr name "aaaaa") - doesn't work:

Failed to save the attribute
Error: {'desc': 'Invalid syntax', 'info': 'attribute type : The name is invalid. Names must begin with a letter'}

The rest looks good :-)

Thanks! All the comments were incorporated (most of them). Please, review!

I will fix with the second PR the standard schema issue. I'll think more how to do it effectively.
Also, I'll fix the table attribute syntax representation in the next PR.

ACK!

Hey there, looks good. Tests for the cli? I think that's about my only comment :)

Hey there, looks good. Tests for the cli? I think that's about my only comment :)

Check the first comment :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3016

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.