Lib389 uses a .replace rather than a path join, causing dirsrv to be replaced in the path. This breaks if the prefix is "/opt/dirsrv".
This should use path join instead.
https://pagure.io/389-ds-base/issue/49939
Author: William Brown william@blackhats.net.au
I've just checked Cockpit UI with your PR and it fails when I try to do any operation in the UI:
This server instance is running, but we can not connect to it. Check LDAPI is properly configured on this instance.
It happens after a normal installation.
Previous ldapi path:
/var/run/slapd-william.socket
WIlliam's LDAPI path:
/var/run/dirsrv/slapd-william.socket
Our official docs say to use:
/var/run/slapd-william.socket.
This is also what the server uses for its default LDAPI path. So I'm not sure why this is breaking for William, but we should stay consistent with the server's default path and what the docs say.
@mreynolds Well the issue is that you can't do a .replace - so there needs to be a better strategy on how to do this? Perhaps we can use "not run_dir" instead? I'll check and send a new patch,
Okay, fixed, it uses local_state_dir now - and add's the run as needed. It's not perfect but it works. I think we wont run into issues in reality.
rebase please :-)
Great, I will rebase soon
rebased onto 4e0e1d857e9c8c058634ba275f9331da5964b8d0
@mreynolds @spichugi This is still a problem and needs review please. Rebasing to master now.
rebased onto 53f91453d9096974df05b843aa8ed929e6cc1a43
Looks like you added this same fix to a different PR (which I just acked)
Yes, because I needed this fix to run that test. I'll merge that branch and close both.
Pull-Request has been closed by firstyear
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/2999
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Lib389 uses a .replace rather than a path join, causing dirsrv to be replaced in
the path. This breaks if the prefix is "/opt/dirsrv".
This should use path join instead.
https://pagure.io/389-ds-base/issue/49939
Author: William Brown william@blackhats.net.au