389-ds-base

#49931 Issue 49928 - Refactor schema CLI/lib389 part to DSLdapObject
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base schema_cliui  into  master

Download 49931.patch

Description: First commit that refactors Schema object and
removes SchemaLegacy usage from CLI.
The commit will be merged with the rest later.
It exists for an easy review.

https://pagure.io/389-ds-base/issue/49928

Reviewed by: ?

Probably shouldn't be here.

Hey just curious. Some of these are opening ldif files. Unless I'm misreading, but I think that anything that's "file" and local only needs to be in dsctl, not dsconf. It would be good to keep schema "purely online" though if possible rather than parsing files ....

Are there test cases to go along with this?

Hey just curious. Some of these are opening ldif files. Unless I'm misreading, but I think that anything that's "file" and local only needs to be in dsctl, not dsconf. It would be good to keep schema "purely online" though if possible rather than parsing files ....

Only schema.file_to_ldap, schema.file_to_subschema, and schema.list_files work with files. And they are not used in any dsconf operation (only lib389 API)...

Are there test cases to go along with this?

It is not the final Schema PR :) , I'll put some tests in the end.

okay, I look forward to the final PR then, and I'll review again more carefully :) Thank you!

rebased onto 9a06c938dc55e81c56a487a15ff8c53b0c5d58c3

Add, edit and remove custom schema tools are here.

Next part is WebUI and some basic CLI tests.
Edited by spichugi

2 new commits added

  • Add add/edit schema options to CLI for objectClasses and attributeTypes
  • Issue 49928 - Refactor schema CLI/lib389 part to DSLdapObject

LGTM

Tests ....?

rebased onto 28c47cfcda9648c6fe9d33d536b005f81f02edf9

rebased onto 219fd4b145462204521dc021290d7b1c5f5cde1b

Tests ....?

It will be added with WebUI (and it will be very basic, our CLI lib389 testing infrastructure still is not in shape).

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2990

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.