You can define constants here - for 'dc=test1,dc=com', 'dc=test2,dc=com', and 'dc=test3,dc=com'. And you can use it instead of the hardcoded values through the test case.

Thanks Simon, updated the test and added few more.
I need to remove "import time" statement as it is unused, need to add more tests here - in coming PR soon.

@vashirov @spichugi Please review the latest PR which includes all the config test cases. Thanks.

I think we should put 'xfail' mark for the failing issue instead of commenting

I think we should also check if it was added or not (present(attr, value) method)

The same check here and another line below

You can write it with for attr_value in ['on', 'off', 'ON', 'OFF']:

You should use DSLdapObject for these operations. You can get it with this function
https://pagure.io/389-ds-base/blob/master/f/src/lib389/lib389/backend.py#_551

And here

@spichugi thanks for the valuable review. Comments are merged.
Please note test_ndn_cache_enabled is not working due to https://pagure.io/389-ds-base/issue/49880

It already exists after the previous test case. It fails

But it is still 'on', you didn't set it to 'off'... Or did I miss something?

:)

Comments incorporated , please check. Thanks for the review.

It should be a decoratore

Corrected. @spichugi please check.

LGTM! Ack

@spichugi rebased the commit. Please merge. Thanks.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2933

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.