Description: Added a test for basic anonymous search operations with various filters
https://pagure.io/389-ds-base/issue/48056
Reviewed by: Simon
You can add it as a fixture - def test_basic_anonymous_search(topology_st, test_users):
@pytest.fixture def test_users(topology_st):
rebased onto 3cd3b7f5ba8f54475501b7a550af8d14d5209625
Fixed and added one more test case. Please review. Thanks.
LGTM, but probably best to wait for @spichugi
I think we can remove 'Verify bug 915801 - ' part because we already mentioned ds604
I am happy with the code. But we will add more test cases as Amita said.
rebased onto 4d7fc46624b5194741329785a6af4ab4fa1d082f
Added one more test case to verify bug 192901, did not find its trac ticket number. Please review.
Please use format 'bz123456', as existing test cases, not 'bug123456'.
Please use 'example.com'
Let's move this number to pytest.mark.bz
typo
rebased onto 722df504116b57d378863e0df56c020869e46ae7
@vashirov @spichugi Thanks for the review. Modified the code and added more test cases. Please check. Thanks.
rebased onto 2b6ea6b47d7b5660f473b9c961562f3ca94a781d
LGTM!
Okay, tests pass and the code looks good.
So please, make a rebase and also change the first commit line... It should be something like this
Issue 48056 - Add more test cases to the basic suite
instead of this
Test basic LDAP operations
The commit message should always follow the same structure. Use the imperative mood in the subject line. A hint, it should sounds like '(This commit will) Add more test cases to the basic suite'
rebased onto b14c836b5ab734c1b59a880afb82522b965e8ad1
Thanks @spichugi for the review. Please check the latest commit.
Pull-Request has been merged by spichugi
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/2931
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description: Added a test for basic anonymous search operations with
various filters
https://pagure.io/389-ds-base/issue/48056
Reviewed by: Simon