I think it will be better if verify_ldif_file will check the whole file. It doesn't cost us much but saves us from many issues in the future.

We can improve it with something like this (ldif is part of python-ldap):

with open("/tmp/export_master2.ldif", 'rb') as f:
    ldif.LDIFRecordList(f).parse()

It will throw an error if the ldif file is bad:

Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "/usr/lib64/python3.6/site-packages/ldif.py", line 461, in parse
    return self.parse_entry_records() # parse()
  File "/usr/lib64/python3.6/site-packages/ldif.py", line 425, in parse_entry_records
    raise ValueError('Line %d: First line of record does not start with "dn:": %s' %     (self.line_counter,repr(k)))
ValueError: Line 28: First line of record does not start with "dn:": 'modifyTimestamp'

If you'll catch it like this, we can have a clean logged error:

with open("/tmp/export_master2.ldif", 'rb') as f:
    try:
        ldif.LDIFRecordList(f).parse()
    except ValueError as e:
        print(e)

It will print Line 28: First line of record does not start with "dn:": 'modifyTimestamp'

@spichugi changes made, thanks!

Couple of small issues here...
First, I think you need to reset the cursor somewhere here, because 'get_dns(MLDIF, opts)' fails overwise. LDIFRecordList will read the data from MLDIF and RLDIF and the cursor will be in the end of the file.

Second, if the LDIFRecordList().parse() fails then we don't close() the MLDIF and RLDIF files...

Overwise, looks good to me!

@spichugi - fixed, please review

thanks!
Ack

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2900

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.