Maybe it makes sense to ask this question earlier (before the LDAPS port). If no self-signed cert will be created, enabling LDAPS doesn't make sense and the LDAPS port question can be skipped.

It seems that this scenario is currently also not covered in the INF file. Maybe, if the LDAPS port in the INF file is set to 0, TLS won't be enabled.

Yes and no, there is no "real" harm setting a secure port even if you aren't using TLS. Feel free to file a ticket to address LDAPS vs self-signed cert validation

@mmuehlfeldrh - made the changes you requested to interactive installer and fromfile installer

The code looks good to me.

One small thing, we have an error in the cockpit instance install action:

usage: dscreate [-h] [-v] {fromfile,interactive,create-template} ...
dscreate: error: invalid choice: 'install' (choose from 'fromfile', 'interactive', 'create-template')

The code looks good to me.
One small thing, we have an error in the cockpit instance install action:
usage: dscreate [-h] [-v] {fromfile,interactive,create-template} ...
dscreate: error: invalid choice: 'install' (choose from 'fromfile', 'interactive', 'create-template')

This is fixed in the UI PR https://pagure.io/389-ds-base/pull-request/49839

Sorry these tickets are overlapping :-/

All CLI installation options work and the code looks good to me. You have my ack.
But maybe Marc has some additional info...

I'm reviewing this now too :)

I need to get a build done, so I'm going to merge this shortly. We can always tweak it later...

That's okay, I'm happy with all of it @mreynolds, looks like you made most of the changes I suggested :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2897

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.