#49821 Issue 49820 - lib389 requires wrong python ldap library
Closed 3 years ago by spichugi. Opened 5 years ago by vashirov.
vashirov/389-ds-base fix-lib389-install  into  master

file modified
+1 -1
@@ -5,4 +5,4 @@ 

  six

  argcomplete

  argparse-manpage

- python3-ldap

+ python-ldap

file modified
+1 -1
@@ -76,7 +76,7 @@ 

          'six',

          'argcomplete',

          'argparse-manpage',

-         'python3-ldap',

+         'python-ldap',

          ],

  

      cmdclass={

Bug Description:
python3-ldap [1] is not the same as python-ldap [2].

[1] https://pypi.org/project/python3-ldap/
[2] https://pypi.org/project/python-ldap/

Fix Description:
Update setup.py and requirements.txt.

https://pagure.io/389-ds-base/issue/49820

Reviewed by: ???

I'm a but confused

[1] https://pypi.org/project/python3-ldap/

This says they renamed it to ldap3.

And what about our spec files where we require python3-ldap, does this mean we have to change those as well? Oo what is different about the specfile requires vs the setup.py/requirements.txt?

Yeah, it's confusing. Fedora and pypi have different namespaces. So the package named python3-ldap can clash with python3-ldap from pypi, which is actually ldap3 -- an incompatible with python-ldap implementation.

Spec file uses naming conventions from Fedora, setup.py/requirements.txt -- from pypi index. So we don't need to change anything in spec file.

Thanks for the clarification! Ack

rebased onto b903b03

5 years ago

Pull-Request has been merged by vashirov

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2880

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago