#49798 Issue 49073 - Add py3 support for tickets
Closed by spichugi. Opened by amsharma.
amsharma/389-ds-base feature  into  master

Download 49798.patch

Description: Added py3 support by explicitly changing strings to bytes.

https://pagure.io/389-ds-base/issue/49588

Reviewed by: ??

This test fails for me with error:

E           lib389.exceptions.NoSuchEntryError: no such entry for [('cn=replica,cn=dc\\3Dexample\\2Cdc\\3Dcom,cn=mapping tree,cn=config', 1, '(&(objectclass=nsds5replicationagreement)(nsds5replicahost=localhost)(nsds5replicaport=39002)(nsds5replicaroot=dc=example,dc=com))')]

Full error log:
https://paste.fedoraproject.org/paste/AoPEN6osp0sovjHh8NKyMw

I think this is the wrong approach. If you have a bytes error it's because you are using the raw entry api, instead of converting to lib389 wrappers. It may be better to rearchitect the test to use the proper lib389 types instead, because one day I would like to remove Entry from lib389 as it's a horrible horrible hack.

We have other tests/tickets ported to Python 3 in the same maner so I think we can merge it like this.

But the test case is really small and should be easy to port. If it is not a big trouble, @amsharma or other collegues, could you please check it?
And please, ask questions if you'll face any issues.

It is very basic UserAccounts test.

Closing this, work will be done in a different PR.

Pull-Request has been closed by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2857

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata