#49764 Ticket 49745 - UI add filter options for error log severity levels
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket49745  into  master

Download 49764.patch

Description: Add a filtering option for error logging that allows
for filtering log content by severity levels. This includes
a generic option for all "errors" and all "info messages"

https://pagure.io/389-ds-base/issue/49745

Reviewed by: ?

You have sev_emerg for "Critical". Probably, it's a mistake

I think you can avoid the repetition if you'll use some dictionary.
For instance like this:

var sev_level_dict = { "Info": " - INFO - ",
                                      "Error": " - ERR - "};

And then you can add one 'else if' here:

} else if (lines[i].indexOf(sev_level_dict[sev_level]) != -1){
        line = lines[i] + "\n";

Probably, you also can group the levels in the dict for "Error Messages" and "Info Messages" but I am not sure which way will be more efficient here, I need to think more.

rebased onto c4e353c630064ab4680e20147bb7cdca2dc0b712

Changes applied.

Looks good to me! Ack.

rebased onto dec51953403df1c9182923487e1ff50015e9e691

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2823

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata