389-ds-base

#49749 Ticket 49748 - Passthru plugin startTLS option not working
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket49748  into  master

Download 49749.patch

Description: While you can configure a connection to use StartTLS the plugin code did not attempt to use StartTLS.

https://pagure.io/389-ds-base/issue/49748

Reviewed by: ?

The patch looks good but I wonder if you should not set ldapversion before and then test it is v3 for start_tls

rebased onto 5254e6f5e8e82d2478316909c5df3bc254b21741

@tbordaz - revised patch, please review...

shouldn't the values for CONN_TRIES and USE_STARTTLS be different ?

For me the patch looks good.
Regarding @lkrispen comment an other option is to use SLAPI_LDAP_INIT_FLAG_SSL and SLAPI_LDAP_INIT_FLAG_startTLS (from salpi-private.h)

rebased onto fa43305b7982aabee522de3db487cb841430593e

The docs for passthru auth plugin say you set "2" to use StartTLS. So using SLAPI_LDAP_INIT_FLAG_startTLS will work. PR is now rebased, please review...

Indeed slapi_ldap_init uses those defines so I guess documented value '2' comes from the defines.
The patch looks good to me. Ack

rebased onto d870eb0d410b59b2624e0aabe5dbeeb0afe94235

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2808

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.