#49723 Ticket 49722 - Errors log full of " WARN - keys2idl - recieved NULL idl from index_read_ext_allids, treating as empty set" messages
Merged 2 years ago by mreynolds. Opened 2 years ago by mreynolds.
mreynolds/389-ds-base ticket49722  into  master

@@ -990,7 +990,7 @@ 

          }

  #endif

          if (idl2 == NULL) {

-             slapi_log_err(SLAPI_LOG_WARNING, "keys2idl", "recieved NULL idl from index_read_ext_allids, treating as empty set\n");

+             slapi_log_err(SLAPI_LOG_WARNING, "keys2idl", "received NULL idl from index_read_ext_allids, treating as empty set\n");

              slapi_log_err(SLAPI_LOG_WARNING, "keys2idl", "this is probably a bug that should be reported\n");

              idl2 = idl_alloc(0);

          }

@@ -966,7 +966,10 @@ 

          slapi_sdn_init_dn_byval(&sdn, val->bv_val);

          rc = entryrdn_index_read(be, &sdn, &id, txn);

          slapi_sdn_done(&sdn);

-         if (rc) { /* failure */

+         if (rc == DB_NOTFOUND) {

+             /* return an empty list */

+             return idl_alloc(0);

+         } else if (rc) { /* failure */

              return NULL;

          } else { /* success */

              rc = idl_append_extend(&idl, id);

Description: If searching on entrydn, and the vblaue is not found return an empty
list instead of NULL. This prevent these harmless error messages in
log

https://pagure.io/389-ds-base/issue/49722

Reviewed by: ?

Typo in the commit message - "vblaue".

And the code looks good to me :)

rebased onto 283a654b5a281a2dbdec9e58ef95731765a457ed

2 years ago

rebased onto e350a26

2 years ago

Pull-Request has been merged by mreynolds

2 years ago