389-ds-base

#49709 Issue 49646 - Improve TLS cert processing in lib389 CLI
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base cert_cli_fix  into  master

Download 49709.patch

Description: Add a new option to setup.inf file - self_sign_cert_valid_months
which accepts int value. dscreate should renew Self-signed CA if
it is expired or it will expire less than in 2 months.
Also, we need to import it to other existing instances.
Remove the NSS DB in the test topology during a teardown.
Fix nss_tls_test.

https://pagure.io/389-ds-base/issue/49646

Reviewed by: ?

It is still a draft and I need to test it more.

But please, review it. Some parts of it already work.

typo numer->number

Those 3 lines are duplicated. An option could be to do a helper function like remove_ssca_db(topology)

rebased onto 2e57fa28c9d558edfcf48fc57816ab96bec858c6

rebased onto 064e7786df3cfb70bb2822d24f9fdade7699f326

LGTM so far

What about something like this instead? (just for readability):

files = [ "%s/%s" % ("certs", f) for f in
          ["key3.db", "cert8.db", "secmod.db",  # dbm backend
           "key4.db", "cert9.db", "pkcs11.txt",  # sql backend
           "noise.txt", "pin.txt", "pwdfile.txt"] ] # support files

And maybe even make the list of files more generally available throughout the code as somewhat similar structure is e.g. just above in _db_exists(self) function.

rebased onto 4409356680cf9cca63036ddb6c5f1d0a8bec08df

rebased onto 02ce5862da0a79fbe5ebf560ff4057426e9e3c15

Explicit call to 'list' function should not be required here, I guess.

rebased onto df1e4ad6ca6065716eb75d9fad720d00c91dadfa

rebased onto 809be53dc8b46a60d99401e40b9625871662b12c

Pull-Request has been merged by mhonek

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2768

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.