Description: A few modals were not converted to PF, and other minor issues with JS and updating tables
https://pagure.io/389-ds-base/issue/49706
Reviewed by: ?
Some tables use default serif font in their headers: Server settings -> Logging -> Access Log -> Access Logging Levels Server settings -> Logging -> Error Log -> Error Logging Levels Security -> Allowed Ciphers Replication -> Replication managers Perhaps they should also be converted to PF.
Buttons at the top (instance selection and actions) also are rendered using custom style instead of PF.
The rest looks good.
Well these are bootstrap tables as recommended in PF docs:
http://www.patternfly.org/pattern-library/widgets/#tables
Datatables are too busy for these IMO, but I could switch them to DT's. Perhaps I can strip off some of the datatable features...
This was intentional, I kind of want to keep them as is. It gives the banner "a little" character. We aren't required to use 100% patternfly for everything - I think 99% is pretty good though :-) But if you feel strongly about it I will change it.
Here's how tables are rendered from the link you gave: https://vashirov.fedorapeople.org/share/pf_table.png And here's how it looks in 389-console: https://vashirov.fedorapeople.org/share/ds_table.png
And buttons for me look like this: https://vashirov.fedorapeople.org/share/buttons.png It's the first thing I notice, that the buttons look different from any other button in Cockpit. Perhaps we can give them more character but in a different way? I'm ok to merge this as it is right now, and we can revisit this in the future (we need a new issue tag - 'bikeshedding' :P ).
And I've just noticed, that we're still trying to load the fonts that we removed (woff2 and ttf files), they are mentioned in patternfly.css that is shipped with 389-console.
Here's how tables are rendered from the link you gave: https://vashirov.fedorapeople.org/share/pf_table.png And here's how it looks in 389-console: https://vashirov.fedorapeople.org/share/ds_table.png And buttons for me look like this: https://vashirov.fedorapeople.org/share/buttons.png
Weird! For me the tables look the same, but your png files are definitely different. What browser are you using? I was using chrome. I also did not add any styling/fonts to the tables btw.
It's the first thing I notice, that the buttons look different from any other button in Cockpit. Perhaps we can give them more character but in a different way? I'm ok to merge this as it is right now, and we can revisit this in the future (we need a new issue tag - 'bikeshedding' :P ).
haha! Perhaps we should
Maybe I'll add those font files back. I'd prefer to not edit the PF css
These were taken in Chrome, but in Firefox I see similar issues. Looks like table header font falls back to sans-serif font if Open Sans, Helvetica or Arial are not found. I've added fonts back and it fixed the problem.
rebased onto 164a9591db34bdd86b2bc0ddd79549c69ce4b08d
I changed the buttons/dropdowns in the banner, and added the font files back that the browser was complaining about
Pull-Request has been merged by mreynolds
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/2766
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description: A few modals were not converted to PF, and other minor issues
with JS and updating tables
https://pagure.io/389-ds-base/issue/49706
Reviewed by: ?