#49692 Issue 49588 - Add py3 support for tickets : part-1
Closed by spichugi. Opened by aadhikari.
aadhikari/389-ds-base python3-support-ticket  into  master

Download 49692.patch

Description: Added py3 support by explicitly changing strings to bytes.
Ported tests from ticket to test suites, also added doc-strings.

https://pagure.io/389-ds-base/issue/49588

Reviewed by: ??

Nice porting! Thanks!

Couple of small things we can improve:

We already use the marks for bugzillas and I think we should continue with it.
You can find the associated BZ in the pagure issue and set it like this:
@pytest.mark.bz1118014
@pytest.mark.bz1257294

You don't have the expected results for the step.

We already use the marks for bugzillas and I think we should continue with it. You can find the associated BZ in the pagure issue and set it like this: @pytest.mark.bz1118014 @pytest.mark.bz1257294

I think we should use ticket numbers (and an optional bz number). Not all tickets have a corresponding bugzilla and not all bugzillas are public.

As for the mark format I propose pytest.mark.ds12345 instead of tk12345 similar to Dev whiteboard in bugzilla.

I think we should use ticket numbers (and an optional bz number). Not all tickets have a corresponding bugzilla and not all bugzillas are public.
As for the mark format I propose pytest.mark.ds12345 instead of tk12345 similar to Dev whiteboard in bugzilla.

Ok, it makes sense. I agree.

Nice porting! Thanks!
Couple of small things we can improve:

Yes, I will change the doc-string in the steps, missed that Thanks ! @spichugi

We already use the marks for bugzillas and I think we should continue with it. You can find the associated BZ in the pagure issue and set it like this: @pytest.mark.bz1118014 @pytest.mark.bz1257294

I think we should use ticket numbers (and an optional bz number). Not all tickets have a corresponding bugzilla and not all bugzillas are public.
As for the mark format I propose pytest.mark.ds12345 instead of tk12345 similar to Dev whiteboard in bugzilla.

Sure will do the appropriate changes, Thanks for looking into this @vashirov

rebased onto 8a2573438650e6b9db2ddd6dc47099b048757208

Ack. Please, rebase it with current master and we can merge.

Ack. Please, rebase it with current master and we can merge.

Sure thanks!

rebased onto a8db015bbcb1fc6f38c3541baa2e20599949f639

rebased onto 262e6aafb86c4e10f47bab593fcce840be1ee04a

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2751

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata