389-ds-base

#49690 Issue 49684 - AC_PROG_CC clobbers CFLAGS set by --enable-debug
Closed by spichugi. Opened by vashirov.
vashirov/389-ds-base debug-cflags  into  master

Download 49690.patch

Bug description:
Default CFLAGS and CXXFLAGS might be unset without --enable-debug.

Fix description:
* Provide default CFLAGS and CXXFLAGS that would be set by AC_PROG_CC
otherwise.
* Split compiler flags and preprocessor flags into separate variables so
they are applied in a correct order.

https://pagure.io/389-ds-base/issue/49684

Reviewed by: ???

Just append /man3 to make it this:

    -rm -rf $(abs_top_builddir)/man/man3

... and you'll fix ticket #49333 as well. ;)
Edited by mhonek

@lslebodn, please take a look at these changes. This PR should fix missing default CFLAGS when none are provided. Thanks!

ACK from me, looks good. I'll fix the man cleanup I mentioned in the separate ticket right after this merges.

rebased onto 8330887e9320a998256cdd13d8715505e87e0826

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2749

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.