389-ds-base

#49676 Ticket 49675 - Fix coverity issues
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base coverity  into  master

Download 49676.patch

Description: Fixed these coverity issues. Some of these fixes are
just to quiet convscan:

16852 Unsigned compared - entrycache_add_int
16848 Unsigned compared - dncache_add_int
16704 Explicit null dereferenced s- lapd_SSL_client_auth
15953 Resource leak - new_task
15583 Out-of-bounds read - create_filter
15445 Unused value - ruv_update_ruv
15442 Argument cannot be negative - dse_write_file_nolock
15223 Double unlock - ruv_get_referrals
15170 Explicit null dereferenced - passwd_apply_mods
15581 Wrong sizeof argument - slapi_be_new
15144 Constant expression result - upgradedn_producer

https://pagure.io/389-ds-base/issue/49675

Reviewed by: ?

rebased onto 2772a29aeeb749e3631ccb4062289fe004d2fa37

I've checked basic, replication acceptance, password and TLS test suites. Everything works fine.

Also, the code looks good to me. But I am not familier with all of the parts of the code base.
So I think, it should be also reviewed by other devs. :)

rebased onto 7e56469b0fb7fbf0929d74b15786b22b0cc42969

ok for me

rebased onto 7a8b5ace5e4a2abdffdfaf737bab80ede4e18eaf

Pull-Request has been merged by mreynolds

@mreynolds, you need to release the lock before returning

If there is not token should we still need to call svrcore_setup ?

Also this function (slapd-SSL-client-auth) returns 'rc'.
But if svrcore_setup fails or token is missing it returns 0. It should return a failure and call slapd_SSL_warn

And coverity just complained about it too. I'll get this fixed...

@tbordaz Token is required in that code block so it must not be NULL.

I handled the error condition for svrcore_setup()/token. I need a new pull request to handle this though...

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2735

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.