Ok, tests are passing.
First, could you please rename the commit's first line so it is different from the previous one.
(you can add 'part 2' or something else)

Second, discard the PEP8 changes for init.py (changes that don't address the "strings to bytes" issue). They create an unnecessary mess in git blame.

Second, discard the PEP8 changes for init.py (changes that don't address the "strings to bytes" issue). They create an unnecessary mess in git blame.

I don't mind making PEP8 linter happy, especially if that reduces the number of warnings. I'd suggest not to discard completely, but split it to a different commit. Is that okay with you, @spichugi?

Second, discard the PEP8 changes for init.py (changes that don't address the "strings to bytes" issue). They create an unnecessary mess in git blame.

I don't mind making PEP8 linter happy, especially if that reduces the number of warnings. I'd suggest not to discard completely, but split it to a different commit. Is that okay with you, @spichugi?

Yes. Though I think PEP8 lint makes sense only for the parts of lib389:
- we want to keep, not some Legacy stuff;
- where it will reduce the number of warnings as you've said, not every point from PEP8.

@spichugi @vashirov I have made the changes as we were discussing above.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2688

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.