#49622 Issue 49585 - Add py3 support to password test suite
Closed by spichugi. Opened by aadhikari.
aadhikari/389-ds-base password  into  master

Download 49622.patch

Description: Added py3 support to password test suite.

https://pagure.io/389-ds-base/issue/49585

Reviewed by: ?

Nice! The change works.
One nitpick only. If you want to fix an existing constant string like 'on'. Do it with b'on' and not with ensure_bytes('on'). It is smaller and we use ensure_bytes() for complex cases only (like when you change existing dynamic variable 'ensure_bytes(very_dynamic_str_var)').

Also, you have a trailing whitespace here

rebased onto 471c25a649e27bdda9ba20e35ff3475a2bead4f3

First, please, mention in the commit description which test suites did you fix.
Also, mention the way you've fixed it ( explicitly changing strings to bytes).

And you need to rebase the commit with recent changes from master.

rebased onto e921d11347b4737ae54738eb3c8c2793a8b3bc01

rebased onto 6900072014856197ddfed71de0be2ab77a2f8af7

rebased onto 355231234ddeb75095b761abcb15300979838bf3

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2681

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata