#49604 Issue 49603 - 389-ds-base package rebuilt on EPEL can't be installed due to missing dependencies
Closed 3 years ago by spichugi. Opened 6 years ago by vashirov.
vashirov/389-ds-base fix-rpm-build-on-epel  into  master

file modified
+7 -5
@@ -121,7 +121,9 @@ 

  # Now, attach the requires only to the package that needs them.

  # -libs has most of our runtime libs

  Requires:         %{name}-libs = %{version}-%{release}

+ %if 0%{?rhel} > 7 || 0%{?fedora}

  Requires:         python%{python3_pkgversion}-lib389 = %{version}-%{release}

+ %endif

  # Attach to -base our script deps

  %if %{use_tcmalloc}

  Requires:         gperftools-libs
@@ -315,7 +317,7 @@ 

             $NSSARGS $TCMALLOC_FLAGS $ASAN_FLAGS $RUST_FLAGS $PERL_FLAGS $CLANG_FLAGS \

             --enable-cmocka

  

- %if 0%{?rhel} >= 8 || 0%{?fedora}

+ %if 0%{?rhel} > 7 || 0%{?fedora}

  make setup.py

  

  # lib389
@@ -341,7 +343,7 @@ 

  # Copy in our docs from doxygen.

  cp -r %{_builddir}/%{name}-%{version}%{?prerel}/man/man3 $RPM_BUILD_ROOT/%{_mandir}/man3

  

- %if 0%{?rhel} >= 8 || 0%{?fedora}

+ %if 0%{?rhel} > 7 || 0%{?fedora}

  # lib389

  pushd src/lib389

  %py3_install
@@ -504,7 +506,7 @@ 

  %{_bindir}/*

  # We have to seperate this from being a glob to ensure the caps are applied.

  %caps(CAP_NET_BIND_SERVICE=pe) %{_sbindir}/ns-slapd

- %if 0%{?rhel} >= 8 || 0%{?fedora}

+ %if 0%{?rhel} > 7 || 0%{?fedora}

  %{_sbindir}/dsconf

  %{_sbindir}/dscreate

  %{_sbindir}/dsctl
@@ -610,14 +612,14 @@ 

  %{_mandir}/man1/ldap-agent.1.gz

  %{_unitdir}/%{pkgname}-snmp.service

  

- %if 0%{?rhel} >= 8 || 0%{?fedora}

+ %if 0%{?rhel} > 7 || 0%{?fedora}

  %files -n python%{python3_pkgversion}-lib389

  %defattr(-,root,root,-)

  %doc LICENSE LICENSE.GPLv3+

  %{python3_sitelib}/lib389*

  %endif

  

- %if 0%{?rhel} >= 8 || 0%{?fedora}

+ %if 0%{?rhel} > 7 || 0%{?fedora}

  %files -n python%{python3_pkgversion}-%{srcname}-tests

  %defattr(-,root,root,-)

  %doc LICENSE LICENSE.GPLv3+

Bug Description:
On EPEL python3 packages are not built, but still mentioned in Requires.
This prevents 389-ds-base from being installed.

Fix Description:
Require python3-lib389 only on Fedora and EPEL > 7. Additionally fix
conditionals according to packaging guidelines.

https://pagure.io/389-ds-base/issue/49603

Reviewed by: ???

rebased onto b05fe2f

6 years ago

Pull-Request has been merged by vashirov

6 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2663

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata