The script fails for me. Not sure if its an env issue (python version?), but I keep seeing these errors:

# PYTHONPATH=/home/mareynol/source/ds389/389-ds-base/src/lib389 py.test ./replcheck_test.py
...
E       TypeError: __init__() got an unexpected keyword argument 'encoding'
/usr/lib64/python2.7/subprocess.py:212: TypeError

As for my initial review, it looks good. Minor issue - we are not testing the verbose conflict entry data (you need the --conflict option), but that can get added later. I think you are also missing a lagtime setting for one of the commands (I'll add a comment in the file).

We might need the lag option set here: '-l', '1',

Lag option? '-l', '1',

I've fixed the test suite according to your comments.

Regarding your error, "/usr/lib64/python2.7/" - you run it with python 2 and the test case uses some features from Python 3.

One small thing. I think we need to mention '--conflict' flag in 'man' and http://www.port389.org/docs/389ds/design/repl-diff-tool-design.html

I'll upload more test cases soon. (for connections through ldaps, ldapi, StartTLS and ldif comparison)

Yeah I updated the man page in my most recent patch for the verbose conflict option (yet to be reviewed). I will also update the design doc.

Note - when I tried using python3 on F26 the CLI tests completely fail to run. is there something special I need to do? (we can discuss that offline if you want)

I think this is the wrong variable name....

R-r-right. :)
Fixed.

ack, I'm happy with this now,

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2626

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.