#623 cleanAllRUV task fails to cleanup config upon completion
Closed: fixed 2 years ago Opened 6 years ago by mreynolds.

It's possible that when issuing a cleanallruv task with the force option set to on, that the config attribute nsds5CleanRuv will not be removed. At restart the task will fire off again.


This issue has nothing to do with the "force" option. There were just issues where the maxcsn might be incorrect. The fix was to just search for the exact value.

I'm curious. Should the search be started from such high level "cn=config"? Or could it be just under Replica entry? Since there is no index in DSE, we may want to heuristically help the search performance. (probably, this operation may not have much performance requirement... so, this comment is a generic one on searching a config entry. ;)
2403 /
2404 * Search the config for the exact attribute value to delete
2405
/
2406 slapi_search_internal_set_pb(pb, "cn=config", LDAP_SCOPE_SUBTREE,   "nsds5ReplicaCleanRUV=", NULL, 0, NULL, NULL,  
2407 (void
)plugin_get_default_component_id(), 0);

git merge ticket623
Updating 98b4232..fa7972a
Fast-forward
.../plugins/replication/repl5_replica_config.c | 106 ++++++++++++++------
1 files changed, 75 insertions(+), 31 deletions(-)

git push origin master
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.91 KiB, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
98b4232..fa7972a master -> master

Reopening this, as we should fix this for 1.2.11 and 1.3.0 branches as well.

git push origin 389-ds-base-1.3.0
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.95 KiB, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
e53d691..a378155 389-ds-base-1.3.0 -> 389-ds-base-1.3.0

git checkout 389-ds-base-1.2.11
Switched to branch '389-ds-base-1.2.11'

git cherry-pick -x fa7972a
Finished one cherry-pick.
[389-ds-base-1.2.11 3d9bd35] Ticket 623 - cleanAllRUV task fails to cleanup config upon completion
1 files changed, 75 insertions(+), 31 deletions(-)

git push origin 389-ds-base-1.2.11
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.94 KiB, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
c535f7d..3d9bd35 389-ds-base-1.2.11 -> 389-ds-base-1.2.11

Bug description: coverity reported "13158 - Logically dead code'

Fix description: csn_as_string returns allocated csn string,
which needs to be reassigned to csnstr.

Pushed to master: commit d5fe6ba (Ticket 623)
Pushed to 389-ds-base-1.3.0: commit 90da6d9 (Ticket 623)
Pushed to 389-ds-base-1.2.11: commit 4d8de55 (Ticket 623)

Coverity defect: 13161: Resource leak

Description: commit d5fe6ba
(coverity fix for "13158 - Logically dead code') introduced
this resource leak. Free csnstr before assigning strdup'ed
string.

Pushed to master: commit 288fb33
Pushed to 389-ds-base-1.3.1 branch: commit 669d82c
Pushed to 389-ds-base-1.3.0 branch: commit 3c107c0
Pushed to 389-ds-base-1.2.11 branch: commit 789270a

Metadata Update from @nhosoi:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.2.11.20

2 years ago

Metadata Update from @spichugi:
- Issue status updated to: Open (was: Closed)

2 years ago

Metadata Update from @spichugi:
- Custom field reviewstatus adjusted to review (was: ack)

2 years ago

Hi Simon I know you didn't add this code, but can you change the sys.exit() calls to "assert False"? I'm not sure, but I thought we don't call the finalizer function if we call exit().

Metadata Update from @mreynolds:
- Custom field reviewstatus adjusted to ack (was: review)

2 years ago

ab81048..486584d master -> master
commit 486584d
Author: Simon Pichugin spichugi@redhat.com
Date: Fri Jun 16 11:14:59 2017 +0200

Metadata Update from @spichugi:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata