Due to how the C plugin api works, the plugin name is a static, which can't easily be created in rust. Today this name is intentionally leaked, but that can trigger LSAN incorrectly.
A solution should be derived that allows LSAN to continue to function, and without the intentional leak.
Metadata Update from @firstyear: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Issue marked as blocking: #51174
Metadata Update from @mreynolds: - Issue priority set to: normal - Issue set to the milestone: 1.4.4
https://pagure.io/389-ds-base/pull-request/51193
Metadata Update from @firstyear: - Issue priority set to: None (was: normal) - Issue set to the milestone: None (was: 1.4.4)
master 017fda070b86844d4860041a6e42ab12d7588836
@mreynolds Did I do the notes correctly this time? :)
Metadata Update from @firstyear: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
https://pagure.io/389-ds-base/pull-request/51193 master 017fda0 @mreynolds Did I do the notes correctly this time? :)
https://pagure.io/389-ds-base/pull-request/51193 master 017fda0
Yes, here's a trick in Pagure, in the commit message prefix the ticket url with "fixes" or "relates" and it will update the issue when you merge it.
relates: https://pagure.io/389-ds-base/issue/51175
Then when you push, it automatically updates the ticket with the commit hash. Then you have to manually add the commits for cherry-picks to earlier versions (if needed). You can see how this works in this ticket: https://pagure.io/389-ds-base/issue/51165
BRB printing this comment and taping it to my face so I don't forget :)
Thanks for the tip! Should we update the suggested git commit message so that this "just works"?
BRB printing this comment and taping it to my face so I don't forget :) Thanks for the tip! Should we update the suggested git commit message so that this "just works"?
We already did some time ago ;-) It references the "fixes" keyword
http://www.port389.org/docs/389ds/contributing.html
BRB printing this comment and taping it to my face so I don't forget :) Thanks for the tip! Should we update the suggested git commit message so that this "just works"? We already did some time ago ;-) It references the "fixes" keyword http://www.port389.org/docs/389ds/contributing.html
We already did some time ago ;-) It references the "fixes" keyword http://www.port389.org/docs/389ds/contributing.html
Hmm, actually, I'm not sure if it needs to be lower case and have the colon. That might actually be coincidence and not put there intentionally. I will update it now...
Clearly I should have checked before I opened my mouth :) thanks mate :)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/4228
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.