pre-commit is a framework for managing and maintaining multi-language pre-commit hooks.
We can integrate various linters/formatters/checkers into our git workflow so that they will be executed automatically on git commit/push or at any other stage. Of course, they can be skipped, if needed.
I propose a list of tools that we should be running by default:
clang-format
black
flake8
flynt
removestar
import *
We also need to add our own checks:
pytest.ini
WDYT?
I agree, we should have these. My advice would be to gradually add them:
Then we do once off runs of flynt and removestar.
It may also be worth considering cargo fmt under src as well.
Metadata Update from @firstyear: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None
Metadata Update from @mreynolds: - Issue priority set to: normal - Issue set to the milestone: 1.4.4
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/4142
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.