#51076 Prevent unnecessarily duplication of the target entry
Closed: fixed 12 days ago by mreynolds. Opened 2 months ago by mreynolds.

Issue Description

When a update operation is performed the MEP plugin unnecessarily duplicates the entry (twice).

This could be related to the performance problem we see with MEP as reported in this ticket:

https://pagure.io/389-ds-base/issue/49318

There are other unnecessary duplications in op_shared_modify() as well


Metadata Update from @mreynolds:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None

2 months ago

Found some other candidates we might be able to remove:

servers/plugins/acctpolicy/acct_plugin.c:    ldrc = slapi_search_internal_get_entry(sdn, NULL, &target_entry,           
servers/plugins/acctpolicy/acct_plugin.c:        ldrc = slapi_search_internal_get_entry(sdn, NULL, &target_entry,       
servers/plugins/acctpolicy/acct_plugin.c:                slapi_search_internal_get_entry(sdn, 0, &e, get_identity()); 
servers/plugins/automember/automember.c:                slapi_search_internal_get_entry(sdn, 0, &e, automember_get_plugin_id());
servers/plugins/pam_passthru/pam_ptpreop.c:            slapi_search_internal_get_entry(sdn, 0, &e,  

Commit bc789a9 fixes this issue

91c5bab..b91683b 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

e1e4ef5..21aa9ab 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

10c85d6..20b1e42 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

Reopening ticket because I think there is more we can do, but it's a bit more intrusive...

Metadata Update from @mreynolds:
- Issue status updated to: Open (was: Closed)

2 months ago

Commit 68ab6a8 relates to this ticket

Commit 68ab6a8 relates to this ticket

c03f549..c32469c 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

bbfaf7c..1076fce 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

cba77de..9c545b9 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

There is still potential to clean up MEP plugin in the pre_op function, will look at this later...

Metadata Update from @mreynolds:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1843156

a month ago

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

12 days ago

Login to comment on this ticket.

Metadata
Related Pull Requests