#51037 RFE AD filter rewriter for ObjectSID
Closed: wontfix 2 years ago by tbordaz. Opened 2 years ago by tbordaz.

Issue Description

LDAP contains 'objectSID' attributes that are binary blob (objectString). A LDAP client can specify an 'objectSID' in a search filter. The assertion value is either a binary blob or a string. The string being a kind of readable shortname with 'objectSID.binary' <=> 'objectSID.string'.

A objectSID.string starts with 'S-'.

The rewriter needs to transform a filter component (only equality) '(objectsid=S-xyz)' into '(objectsid=<binary representation of 'S-xyz')'

Package Version and Platform

N/A

Steps to reproduce

Creates entries with ObjectSID values.

Then lookup for those entries using '(objectsid=S-...)'

Actual results

Expected results


Metadata Update from @tbordaz:
- Issue assigned to tbordaz

2 years ago

Metadata Update from @mreynolds:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Issue priority set to: major
- Issue set to the milestone: 1.4.3

2 years ago

Metadata Update from @tbordaz:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Not so fast, got a complier warning:

../389-ds-base/src/rewriters/adfilter.c: In function ‘substitute_string_objectsid’:
../389-ds-base/src/rewriters/adfilter.c:281:22: warning: pointer targets in assignment from ‘uint8_t *’ {aka ‘unsigned char *’} to ‘char *’ differ in signedness [-Wpointer-sign]
  281 |         bval->bv_val = bin_sid.sid;
      |                      ^
../389-ds-base/src/rewriters/adfilter.c:192:11: warning: unused variable ‘newval’ [-Wunused-variable]
  192 |     char *newval;
      |           ^~~~~~

Metadata Update from @mreynolds:
- Issue status updated to: Open (was: Closed)

2 years ago

Metadata Update from @tbordaz:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/4090

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

a year ago

Login to comment on this ticket.

Metadata