systemtap and callgrind analysis show a lot of time spent in this code in both thread contention and malloc/free - we need to find a less malloc/free and lock/mutex intensive way to determine if the DN RDN attribute has DN syntax
The locking problem should be resolved by ticket 504.505. The malloc/free could be avoided by replacing slapi_attr_init/done by a call to attrsyntax_get_by_name() since the attr is not needed. It could be done in a function is_dn_syntax(attrtypename).
attachment 0001-Fix-for-ticket-510.patch
When you add an new slapi-plugin api, could you add the description, as well in slapi-plugin.h? Something like this?
{{{ / * Adds a value to an attribute. * \param a The attribute that will contain the values. * \param v Value to be added to the attribute. * \return Always returns 0. * \see slapi_attr_first_value() * \see slapi_attr_next_value() * \see slapi_attr_get_numvalues() * \see slapi_attr_value_cmp() * \see slapi_attr_value_find() / }}}
Metadata Update from @lkrispen: - Issue assigned to lkrispen - Issue set to the milestone: 1.3.0
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/510
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.