#50998 Implement Filter module for cn=changelog in lib389
Closed: wontfix 3 years ago by spichugi. Opened 4 years ago by aborah.

Issue Description: Implement Filer module for cn=changelog in lib389


What do you mean ? What are you trying to achieve here?

Metadata Update from @firstyear:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None

4 years ago

The separate cn=changelog config will go away, see ticket #49562.

So I would not invest time for the old changelog

or did you mean the retro changelog ?

@vashirov can clearly tell us more .

Actually i was trying to replace this command:

master.search_s("cn=changelog", ldap.SCOPE_SUBTREE, "(objectclass=*)", ["dn"])

with

retro = RetroChangelog(master)
retro.filter("(objectclass=*)")

where

   class RetroChangelog(DSLdapObjects):
         def __init__(self, instance, dn='cn=changelog'):
               super(RetroChangelog, self).__init__(instance, dn)
               self._rdn_attribute = 'cn'
               self._must_attributes = ['cn', 'nsslapd-changelogdir']
              self._create_objectclasses = [
              'top',
              'nsChangelogConfig',
         ]

ok, so it is the RetroChangelog, and I do still not know what you need to achieve, but this part

 class RetroChangelog(DSLdapObjects):
 """Represents the Directory Server changelog. This is used for
      replication. Only one changelog is needed for every server.

is clearly false. Retro Changelog is NOT used for replication

ok, so it is the RetroChangelog, and I do still not know what you need to achieve, but this part
class RetroChangelog(DSLdapObjects):
"""Represents the Directory Server changelog. This is used for
replication. Only one changelog is needed for every server.

is clearly false. Retro Changelog is NOT used for replication

Corrected

What do you mean ? What are you trying to achieve here?

This is needed to port old betxn tests for retro changelog. In the tests there are search operations on cn=changelog, but since search_s is not recommended, we're trying to create a proper DSLdapObject to use in the tests.
Do you think there is a better way to do this?

Metadata Update from @mreynolds:
- Issue priority set to: normal
- Issue set to the milestone: 1.4.3

4 years ago

No making the dsldapobjects here is fine, I think @lkrispen's point is just about correctly naming the changelog vs retrochangelog.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/4051

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata