Our Web UI source files are too big and we should make it compact for the production. Compress and decrease the size of the files that are generated by webpack. Fix rpm.mk so it delivers RPMs only with production-ready result files (we can skip js.map because it is used only for development)
production-ready
js.map
https://pagure.io/389-ds-base/pull-request/50843
Metadata Update from @spichugi: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None
46daeac..06d55f9 389-ds-base-1.4.1 -> 389-ds-base-1.4.1 b8f99b7..ed29ead 389-ds-base-1.4.2 -> 389-ds-base-1.4.2
Metadata Update from @spichugi: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
126bfa0 breaks make -f rpm.mk srpms for me (the parent commit works ok). The last words are following:
make -f rpm.mk srpms
> 389-console@1.0.0 build /home/vagrant/ds/src/cockpit/389-console > webpack Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration. (node:29652) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard-react") (node:29652) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "node_modules/eslint-config-standard-jsx/index.js") (node:29652) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard") Browserslist: caniuse-lite is outdated. Please run next command `npm update caniuse-lite browserslist` ~/bin/sh: line 1: 29641 Killed npm run build make[1]: *** [node_modules.mk:7: build-cockpit-plugin] Error 137 make[1]: Leaving directory '/home/vagrant/ds/src/cockpit/389-console' make: *** [rpm.mk:55: build-cockpit] Error 2
This is an out-of-box build. Any ideas?
What nodejs and npm versions do you have? It works for me with
$ rpm -q nodejs npm nodejs-12.14.1-2.fc31.x86_64 npm-6.13.4-1.12.14.1.2.fc31.x86_64
Thanks, Viktor. It indeed is an OOM kill (1GB RAM VM). I'm on F30 with:
nodejs-10.16.3-1.fc30.x86_64 npm-6.9.0-1.10.16.3.1.fc30.x86_64
Funny. I tested with the same specs but on F31 and no OOM kill, works as it should. Maybe they fixed something in nodejs between versions 10 and 12.
I'm seeing these warnings now with this fix:
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance. Assets: index.min.js.gz (384 KiB) static/bootstrap.min.css.map (529 KiB) WARNING in webpack performance recommendations: You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application. For more info visit https://webpack.js.org/guides/code-splitting/
Reopening to investigate if there is more we can do to help performance...
Metadata Update from @mreynolds: - Issue status updated to: Open (was: Closed)
Metadata Update from @mreynolds: - Issue set to the milestone: 0.0 NEEDS_TRIAGE
Metadata Update from @mreynolds: - Issue set to the milestone: 1.4.1 (was: 0.0 NEEDS_TRIAGE)
Yeah, we can separate the entry points (now we have only 'index') and it will resolve the issue.
But I'd rather do it together with the final React porting commit, so we can avoid a double refactoring.
Metadata Update from @mreynolds: - Issue priority set to: minor
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/3896
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.