Attempting to use a wildcard in the rootdn-allow-ip attribute of the rootdn_access plugin causes the server to fail to start:
ERR - rootdn-access-control-plugin - rootdn_load_config - IP address contains invalid characters (127.*), skipping ERR - rootdn-access-control-plugin - rootdn_init - Unable to load plug-in configuration ERR - plugin_setup - Init function "rootdn_init" for "RootDN Access Control" plugin in library "librootdn-access-plugin" failed ERR - load_plugin_entry - Unable to load plugin "cn=RootDN Access Control,cn=plugins,cn=config"
The use of wildcards is documented and was allowed when the plugin was originally added, but the changes in #48027 unintentionally broke the parsing of values containing a *.
*
Quick/untested fix at https://pagure.io/fork/yrro/389-ds-base/diff/master..rootdn-allow-ip-wildcards.
Hey @yrro did you want to make this fix a PR so that we can comment and discuss it there?
Thanks for reporting the issue by the way :)
Metadata Update from @firstyear: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None
Here you go: https://pagure.io/389-ds-base/pull-request/50803
Thanks! I'll review further there.
Metadata Update from @mreynolds: - Issue set to the milestone: 1.3.10
Metadata Update from @mreynolds: - Issue set to the milestone: 1.4.1 (was: 1.3.10)
Metadata Update from @mreynolds: - Issue priority set to: major
Metadata Update from @mreynolds: - Issue set to the milestone: 1.3.10 (was: 1.4.1)
Metadata Update from @mreynolds: - Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1807537
Issue linked to Bugzilla: Bug 1807537
Metadata Update from @mreynolds: - Issue assigned to mreynolds
Thanks for the original patch @yrro
I had to make a few changes to get the test case to run correctly, so I ended up creating a new PR
https://pagure.io/389-ds-base/pull-request/50965
Please review...
Commit c4befd6 relates to this ticket
6e997ea..d8f2994 389-ds-base-1.4.2 -> 389-ds-base-1.4.2
31be5e4..b811ee0 389-ds-base-1.4.1 -> 389-ds-base-1.4.1
811db90..6ced3f5 389-ds-base-1.3.10 -> 389-ds-base-1.3.10
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/3854
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.