#50736 RetroCL trimming may crash at shutdown if trimming configuration is invalid
Closed: fixed 6 months ago by vashirov. Opened 9 months ago by tbordaz.

Issue Description

The crash occurs when nsslapd-changelogmaxage is invalid (like -1). In such case the trimming structures are not allocated but at shutdown they are freed

#0  0x00007f2d45960cd1 in __GI___pthread_mutex_destroy (mutex=mutex@entry=0x0) at pthread_mutex_destroy.c:30
#1  0x00007f2d45fb8e39 in PR_DestroyLock (lock=0x0) at ../../../nspr/pr/src/pthreads/ptsynch.c:155
#2  0x00007f2d384acc36 in retrocl_stop_trimming () at ldap/servers/plugins/retrocl/retrocl_trim.c:489
#3  0x00007f2d384a8eb7 in retrocl_stop (pb=<optimized out>) at ldap/servers/plugins/retrocl/retrocl.c:621
#4  0x00007f2d4820b028 in plugin_call_func (list=0x560a31b95080, operation=operation@entry=210, pb=pb@entry=0x560a4d28f1a0, call_one=call_one@entry=1) at ldap/servers/slapd/plugin.c:2028
#5  0x00007f2d4820e542 in plugin_call_one (pb=0x560a4d28f1a0, operation=210, list=<optimized out>) at ldap/servers/slapd/plugin.c:1978
#6  0x00007f2d4820e542 in plugin_dependency_closeall () at ldap/servers/slapd/plugin.c:1876
#7  0x00007f2d4820e575 in plugin_closeall (close_backends=close_backends@entry=1, close_globals=close_globals@entry=1) at ldap/servers/slapd/plugin.c:1965
#8  0x0000560a30714e84 in slapd_daemon (ports=ports@entry=0x7ffe314d0f40, tp=tp@entry=0x0) at ldap/servers/slapd/daemon.c:1279
#9  0x0000560a30705ac5 in main (argc=<optimized out>, argv=0x7ffe314d13b8) at ldap/servers/slapd/main.c:1204

Package Version and Platform

All versions

Steps to reproduce

reproducible testcase to provide.
1 - enable retroCL
2 - configure nsslapd-changelogmaxage=-1
3 - restart server
4 - do some updates (optional)
5 - stop the server

Actual results

It crashes

Expected results

Should not crash

Metadata Update from @tbordaz:
- Custom field origin adjusted to IPA
- Custom field reviewstatus adjusted to None
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1763365

9 months ago

Metadata Update from @tbordaz:
- Issue assigned to tbordaz
- Issue set to the milestone: 0.0 NEEDS_TRIAGE

9 months ago

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.3.10 (was: 0.0 NEEDS_TRIAGE)

8 months ago

6200037..7e39425 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

b1fb4bb..881a53f 389-ds-base-1.4.0 -> 389-ds-base-1.4.0

b6ba778..e415129 389-ds-base-1.3.10 -> 389-ds-base-1.3.10

Metadata Update from @vashirov:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

6 months ago

Login to comment on this ticket.