#50617 New releases don't compile
Closed: wontfix 4 years ago by firstyear. Opened 4 years ago by svenstaro.

Issue Description

I tested 1.4.1.7 and 1.4.2.1 and they both fail to compile due to - I think - someone forgetting to run cargo update.

Relevant excerpt from make:

gcc -DHAVE_CONFIG_H -I.    -DRUST_ENABLE -DBUILD_NUM=\"2019.262.2337\" -DVENDOR="\"389 Project\"" -DBRAND="\"389\"" -DCAPBRAND="\"389\"" -UPACKAGE_VERSION -UPACKAGE_TARNAME -UPACKAGE_STRING -UPACKAGE_BUGREPORT -I./ldap/include -I./ldap/servers/slapd -I./include -I. -I./src/nunc-stans/include/ -DLOCALSTATEDIR="\"/var\"" -DSYSCONFDIR="\"/etc\"" -DLIBDIR="\"/usr/lib\"" -DBINDIR="\"/usr/bin\"" -DDATADIR="\"/usr/share\"" -DDOCDIR="\"/usr/share/doc/389-ds-base\"" -DSBINDIR="\"/usr/bin\"" -DPLUGINDIR="\"/usr/lib/dirsrv/plugins\"" -DTEMPLATEDIR="\"/usr/share/dirsrv/data\"" -DSYSTEMSCHEMADIR="\"/usr/share/dirsrv/schema\"" -DWITH_SYSTEMD -DHAVE_JOURNALD -I./src/nunc-stans/include/ -I/usr/include -I/usr/include/nss -I/usr/include/nspr  -I/usr/include/nspr    -I./src/svrcore/src/ -D_FORTIFY_SOURCE=2 -g -O2      -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -MT ldap/servers/slapd/ns_slapd-psearch.o -MD -MP -MF ldap/servers/slapd/.deps/ns_slapd-psearch.Tpo -c -o ldap/servers/slapd/ns_slapd-psearch.o `test -f 'ldap/servers/slapd/psearch.c' || echo './'`ldap/servers/slapd/psearch.c
error: the lock file /build/389-ds-base/src/389-ds-base-1.4.1.7/src/libsds/Cargo.lock needs to be updated but --locked was passed to prevent this
make[1]: *** [Makefile:14494: /build/389-ds-base/src/389-ds-base-1.4.1.7/rs/release/librsds.a] Error 101
make[1]: *** Waiting for unfinished jobs....
mv -f ldap/servers/slapd/.deps/ns_slapd-getopt_ext.Tpo ldap/servers/slapd/.deps/ns_slapd-getopt_ext.Po
mv -f ldap/servers/slapd/.deps/ns_slapd-init.Tpo ldap/servers/slapd/.deps/ns_slapd-init.Po
mv -f ldap/servers/slapd/.deps/ns_slapd-abandon.Tpo ldap/servers/slapd/.deps/ns_slapd-abandon.Po

Package Version and Platform

1.4.1.7 and 1.4.2.1 on Arch Linux.

Steps to reproduce

  ./configure \
    --prefix=/usr \
    --sysconfdir=/etc \
    --sbindir=/usr/bin \
    --localstatedir=/var \
    --libexecdir=/usr/lib/${pkgbase} \
    --with-tmpfiles-d=/usr/lib/tmpfiles.d \
    --with-systemd \
    --with-systemdsystemunitdir=/usr/lib/systemd/system \
    --with-systemdsystemconfdir=/etc/systemd/system \
    --with-journald \
    --enable-autobind \
    --enable-cmocka \
    --with-openldap \
    --enable-rust
  make

Actual results

error: the lock file /build/389-ds-base/src/389-ds-base-1.4.1.7/src/libsds/Cargo.lock needs to be updated but --locked was passed to prevent this

Expected results

Clean compile


Try disable-rust as a work around. I'll resolve this issue asap (likely early next week)

Metadata Update from @firstyear:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None

4 years ago

Metadata Update from @firstyear:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Thanks for the fix. I'd like to note that I don't think that disabling the --locked feature is the proper way to go about this. It should be fairly easy to add a cargo update to your pre-release scripts which will make sure that all the deps are in sync and that --locked will be happy.

@svenstaro Correct, it's not the correct way to fix this. I need to get a proper release pipeline and tooling in place for cargo vendor + --offline/--locked builds to work. So until I do this work, it's better to just leave locked disabled.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3672

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

3 years ago

Login to comment on this ticket.

Metadata