Some plugins have their config pre-created in dse.ldif template, some don't. When a Plugin object is created, it doesn't check the presence of the config dn. And we end up writing supporting code for each case. Plugin class should check if the config dn is present, and create it if not.
dse.ldif
Plugin
There is already a stateful "create" option which is "create if not exist, or update to match this definition" as part of DSLdapObject, so you just need to use that function instead of create. It's "ensure_state".
Metadata Update from @firstyear: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None
Shouldn't we use it by default for plugins then?
Yes we should ... I think that this function was made "after" people started using create, and maybe didn't know it existed.
Metadata Update from @mreynolds: - Issue set to the milestone: 1.4.1
Metadata Update from @firstyear: - Issue assigned to firstyear
Metadata Update from @firstyear: - Assignee reset
Metadata Update from @mreynolds: - Issue priority set to: minor - Issue set to the milestone: 1.4.3 (was: 1.4.1)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/3572
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.