#50348 Evaluate what prevents Filter bypass and what is the gain of it
Closed: wontfix 3 years ago by spichugi. Opened 4 years ago by firstyear.

Issue Description

There are very few cases where the filter test can accurately be bypassed, and generally it has to be applied to determine ACI's as well.

The idea of a filter test bypass actually violates the principle correct-simple-fast, where we should always assert that our content matches the provided filter, given the fact that partial candidates and more can exist.

In fact, a great deal of logic around ALLIDS and flagging these would be able to be removed if this was assumed to always run. It would also make consistent behaviour with regard to application of ACI and correct query execution behaviour.

I think this should default to OFF.

https://pagure.io/389-ds-base/pull-request/50252#comment-85208


After discussion with @lkrispen this may be better as an investigation into the correctness and operation of grok-filter as today it may be too broad or zealous. @lkrispen has pointed out there may be a large performance improvement on large sets in this situation by avoiding the filter test.

Metadata Update from @firstyear:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None

4 years ago

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.4.2

4 years ago

@firstyear , @lkrispen , as of today I have not a clear understanding if filter bypass is still working or not. I agree with https://pagure.io/389-ds-base/issue/50348#comment-577228 that filter bypass should bring performance improvement.

I propose to change the subject of the ticket in order to make sure filter bypass is still working as expected and how much it is is beneficial.

Do you agree ?

Yes, I agree with that. Today I think grok filter almost always evals to a situation where we don't bypass, so perhaps checking this is a good thing.

@firstyear thanks for your feedback. Changing the title and moving it to 1.4.3.

Metadata Update from @tbordaz:
- Issue set to the milestone: 1.4.3 (was: 1.4.2)

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3407

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata