lib389 is designed to have objects encapsulate behaviour, and to move data to locations that determine how to handle that data. The get_status function of the Monitor types doesn't do this correctly opting to print directly. The issue is if someone used get_status and was expecting a dictionary as a return, and wanted to format the output in a certain way, consume the output for a lookup, or wanted to write their own scripts to extend this functionality.
get_status on monitor types (and it's callers) need to returne a dict, and then the caller should be responsible for the display of the data.
Metadata Update from @mreynolds: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Issue set to the milestone: 1.4.1
Metadata Update from @mreynolds: - Issue priority set to: minor - Issue set to the milestone: 1.4.3 (was: 1.4.1)
I accidentally fixed this in #50545 :-) Closing this as a duplicate...
Metadata Update from @mreynolds: - Issue close_status updated to: duplicate - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/3248
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: duplicate)
Login to comment on this ticket.