Needs to go in 1.3.9 as well

Okay, I'll make sure this is put in 1.3.9 too. This is still waiting review I think.

In 1.3.9 we need only tmpfiles_d to be present in defaults.inf to make our testing easier. The rest of the patch is nice to have, but is not necessary.

@mreynolds Does this need to be in 1.3.9? It looks like that branch doesn't have tmpfiles_d support at all?

@mreynolds Does this need to be in 1.3.9? It looks like that branch doesn't have tmpfiles_d support at all?

In that case probably not. I forget the actual conversation where this came up (dealing with a cold right now - not 100%). @vashirov does this ring a bell? Sounds like 1.3.9 can be skipped, or we need to backport more patches :-)

The backstory is that 1.3.x doesn't have the same defaults.inf file as 1.4.x and master, but we run lib389 and tests on 1.3.x from master. So lib389 assumes that some value should be there and fails to run the tests if it's missing (even though an old perl installer is used). I have a workaround in our automation, but it would be nice to not have it.
So, as I mentioned above, we need only this line to be present there: https://pagure.io/389-ds-base/blame/ldap/admin/src/defaults.inf.in?identifier=master#_44

Okay, so to be sure - is there something I need to do with this to make sure I haven't make any mistakes etc? Because I haven't touched the 1.3.x branch the existing defaults.inf should be valid then ...

It needs to be in sync with the master branch, because it is used by lib389 from the master branch. It's not used by old perl tools, so the change won't break anything on 1.3.x. Here's the current diff:

$ git diff 389-ds-base-1.3.9.0 master -- ldap/admin/src/defaults.inf.in
diff --git a/ldap/admin/src/defaults.inf.in b/ldap/admin/src/defaults.inf.in
index 8565ff7a0..f74929581 100644
--- a/ldap/admin/src/defaults.inf.in
+++ b/ldap/admin/src/defaults.inf.in
@@ -1,12 +1,13 @@
 ; --- BEGIN COPYRIGHT BLOCK ---
 ; Copyright (C) 2016 Red Hat, Inc.
+; Copyright (C) 2019 William Brown <william@blackhats.net.au>
 ; All rights reserved.
 ;
 ; License: GPL (version 3 or any later version).
 ; See LICENSE for details.
 ; --- END COPYRIGHT BLOCK ---

-; Author: firstyear at redhat.com
+; Author: wbrown at suse.de

 ; This is a set of default paths that tools consuming DS should search
 ; for paths. This is the foundation of the version 2 ds setup inf
@@ -34,10 +35,13 @@ initconfig_dir = @initconfigdir@
 config_dir = @instconfigdir@/slapd-{instance_name}
 local_state_dir = @localstatedir@
 run_dir = @localstatedir@/run/dirsrv
+# This is the expected location of ldapi.
+ldapi = @localstatedir@/run/slapd-{instance_name}.socket
 pid_file = @localstatedir@/run/dirsrv/slapd-{instance_name}.pid
-inst_dir = @serverdir@
+inst_dir = @serverdir@/slapd-{instance_name}
 plugin_dir = @serverplugindir@
 system_schema_dir = @systemschemadir@
+tmpfiles_d = @tmpfiles_d@

 ; These values can be altered in an installation of ds
 user = dirsrv

The latest merge broke dscreate, reopeing issue. Please fix asap, or revert.

[mareynol@localhost cli]$ sudo ./dscreate from-file /data/dssetup.inf

Starting installation...
Created symlink /etc/systemd/system/multi-user.target.wants/dirsrv@localhost.service → /usr/lib/systemd/system/dirsrv@.service.
Error: [Errno 2] No such file or directory: '@tmpfiles_d@/dirsrv-localhost.conf'

Looks like I had a mixed matched rpms on my system - I do not see this error anymore, but I do see other new problems now in dscreate, but I will open a new ticket for that. Sorry for the noise.

So you want these values from defaults.inf put into 1.3.9 then? Is that correct?

So you want these values from defaults.inf put into 1.3.9 then? Is that correct?

Yes, I filed PR https://pagure.io/389-ds-base/pull-request/50357

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3182

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.