#50062 Replace error by warning in the state machine defined in repl5_inc_run
Closed: fixed 8 months ago Opened 8 months ago by mreynolds.

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 7): Bug 1639342

Description of problem:

Just a simple request to replace an error by a warning:

            } else if ((e1 = event_occurred(prp, EVENT_WINDOW_CLOSED)) ||
                       event_occurred(prp, EVENT_BACKOFF_EXPIRED)) {
                /* this events - should not occur - log a warning and go to
sleep */
                slapi_log_err(SLAPI_LOG_ERR, repl_plugin_name,
                              "repl5_inc_run - %s: "
                              "Event %s should not occur in state %s; going to
sleep\n",
                              agmt_get_long_name(prp->agmt), e1 ?
event2name(EVENT_WINDOW_CLOSED) : event2name(EVENT_BACKOFF_EXPIRED),
state2name(current_state));
                protocol_sleep(prp, PR_INTERVAL_NO_TIMEOUT);


So, as it's just a warning, let's replace SLAPI_LOG_ERR by SLAPI_LOG_WARNING.

Same in windows inc protocol:


           } else if ((e1 = event_occurred(prp, EVENT_WINDOW_CLOSED)) ||
                       event_occurred(prp, EVENT_BACKOFF_EXPIRED)) {
                /* this events - should not occur - log a warning and go to
sleep */
                slapi_log_err(SLAPI_LOG_ERR, windows_repl_plugin_name,
                              "windows_inc_run - %s: "
                              "Event %s should not occur in state %s; going to
sleep\n",
                              agmt_get_long_name(prp->agmt),
                              e1 ? event2name(EVENT_WINDOW_CLOSED) :
event2name(EVENT_BACKOFF_EXPIRED),
                              state2name(current_state));




Version-Release number of selected component (if applicable): rhel-7.5

Metadata Update from @mreynolds:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1639342

8 months ago

Metadata Update from @mreynolds:
- Issue assigned to mreynolds

8 months ago

Metadata Update from @mreynolds:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None
- Issue set to the milestone: 1.3.9 (was: 0.0 NEEDS_TRIAGE)

8 months ago

d808e3d..181ff36 389-ds-base-1.3.9 -> 389-ds-base-1.3.9

Metadata Update from @mreynolds:
- Assignee reset
- Issue close_status updated to: fixed
- Issue set to the milestone: 0.0 NEEDS_TRIAGE (was: 1.3.9)
- Issue status updated to: Closed (was: Open)

8 months ago

Login to comment on this ticket.

Metadata