#50060 "make 389-console" should work from outside of source tree
Closed: wontfix 2 years ago by mreynolds. Opened 3 years ago by mreynolds.

Issue Description

We should be able to run "make 389-console" from any build root. This works for other "make" options as described on the wiki. What is nice about this is that you do not pollute the local source tree with the build artifacts:

http://www.port389.org/docs/389ds/development/building.html#build-locally

So for example I create:

 source/BUILD_UI/
 source/389-ds-base  <-- DS source code

Then in BUILD_UI/ I run a configure command that points back to "../389-ds-base/configure", and I run "make install" for example.

But trying "make 389-console" from this location fails with the current implementation as it looks like the paths are hardcoded:

[mareynol@localhost BUILD_UI]$ make 389-console
cd src/cockpit/389-console; make -f node_modules.mk build-cockpit-plugin
/bin/sh: line 0: cd: src/cockpit/389-console: No such file or directory
make[1]: Entering directory '/home/mareynol/source/ds389/BUILD_UI'
make[1]: node_modules.mk: No such file or directory
make[1]: *** No rule to make target 'node_modules.mk'.  Stop.
make[1]: Leaving directory '/home/mareynol/source/ds389/BUILD_UI'
make: *** [Makefile:13029: src/cockpit/389-console/cockpit_dist/index.html] Error 2

This should be functional.


I think we also need to revisit all the new "make commands".

make install ---> this should do everything build the server and the console, and install it all (typically run as root)
make 389-console --> this should do all the console building. No need to run "make -f node_modules.mk install", or anything else.
make 389-console-devel-install --> Install cockpit into users's local share cockpit directory.

I think some of this works, but not all of it

Metadata Update from @mreynolds:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

3 years ago

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.4.0

3 years ago

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3119

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

2 years ago

Login to comment on this ticket.

Metadata