We are logging, console.log(), all the CLI commands in the UI. To make sure the formatting is consistent we should create a simple logging function:
log_cmd(js_function_name, cmd_description_text, cmd_array); log_cmd("load_repl_config", "Load all the replication data into the UI forms", cmd);
Console output:
CMD: load_repl_config - Load all the replication data into the UI forms: dsconf -j ldapi://%2fvar%2frun%2fslapd-localhost.socket replication get --suffix=dc=example,dc=com
Good idea. Additionally, however, I believe the logging itself should be turned off by default in production, and only turned on when the user explicitly asks for it, maybe some hidden checkbox. And, the call itself should be guarded for existence as the console.log() may not be present in some browsers, hence it has potential to generate a lot of errors in the console itself.
console.log()
Metadata Update from @mhonek: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None
@mhonek Flip side is that console logging is cheap on the client, and will make error report submissions simpler. I think logging by default is fine for this application,
However, console.log not being universal ... is that true? I would hope we could find a way to standardise or detect what logging we need inside the log_cmd.
https://pagure.io/389-ds-base/pull-request/49982
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to review (was: None)
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/3037
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.