Fix the latest issues reported by coverity.
<img alt="0001-t49573-coverity-issues-part-1.patch" src="/389-ds-base/issue/raw/files/5eaa8e28bbb804f19bc920df5e2637a37ce4235736b39ca24f30a8d1db7dc237-0001-t49573-coverity-issues-part-1.patch" />
Metadata Update from @lkrispen:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None
Metadata Update from @mreynolds:
- Issue set to the milestone: 1.4.0
The code looks good to me, but I think I'll ask @mreynolds or @tbordaz to check too :)
<img alt="0001-t49573-coverity-issues-part-2.patch" src="/389-ds-base/issue/raw/files/0617b0b3d016001ae275765a7b0757b78870d6a5612fcfd6eff7f24c24c02dda-0001-t49573-coverity-issues-part-2.patch" />
I marked several reported issues as false positive, most of them related to slpai_pblock_set(). If we set a ptr we can pass NULL, but coverity tarcks a case where a ptr to int would be passed and dereferenced.
To completely avoid this, and maybe make our code more clean, we could define type specific setter and getter functions for pblock, eg slapi_pblock_set_int(), slapi_pblock_set_addr(),....
Metadata Update from @vashirov:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here:
If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)
to comment on this ticket.