#49573 Fix issues reported by coverity for 389-ds-base-1.4.0.5.20180216git9e2009a
Closed: wontfix 2 years ago by vashirov. Opened 4 years ago by vashirov.

Fix the latest issues reported by coverity.


Metadata Update from @lkrispen:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

4 years ago

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.4.0

4 years ago

The code looks good to me, but I think I'll ask @mreynolds or @tbordaz to check too :)

I marked several reported issues as false positive, most of them related to slpai_pblock_set(). If we set a ptr we can pass NULL, but coverity tarcks a case where a ptr to int would be passed and dereferenced.
To completely avoid this, and maybe make our code more clean, we could define type specific setter and getter functions for pblock, eg slapi_pblock_set_int(), slapi_pblock_set_addr(),....

Metadata Update from @vashirov:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2632

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

2 years ago

Login to comment on this ticket.

Metadata