The replication code has a mechanism to write the changelog RUV to the changelog database file when on online backup is done. Before the backup it is written and after the backup it is removed again. But if there are any mods while the backup proceeds (this is the feature of online, the txn logs will be in the backup and at restore all mods during backup will be recovered).
But in this scenario the changelog RUV and the database RUV will not match and at restore the changelog will be recreated and lost. The correct method would be NOT to write the changelog RUV, at restore it will be recalculated from the changelog an set
<img alt="0001-do-not-write-changlog-RUV-in-online-backup.patch" src="/389-ds-base/issue/raw/files/8aea603298f32f55c2068fb282028333ecf53e9eb6b94c1f01158b9ec0208bc7-0001-do-not-write-changlog-RUV-in-online-backup.patch" />
Metadata Update from @lkrispen: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None
I'm not sure if this is ready for review, but it looks good to me, ack
no, wanted to add a test case, but didn't want to loose the patch
Like @mreynolds the patch looks good to me and I am happy to remove no longer used code. SLAPI_PLUGIN_BE_PRE_BACKUP_FN and SLAPI_PLUGIN_BE_POST_BACKUP_FN are not documented but are in slapi-plugin.h. Is ok to remove them.
Like @mreynolds the patch looks good to me and I am happy to remove no longer used code.
It is used, but I think it should not be used.
Metadata Update from @mreynolds: - Issue set to the milestone: 1.4.0
I will implement this as part of the changes for #49562
Metadata Update from @vashirov: - Issue marked as depending on: #49562 - Issue priority set to: normal - Issue set to the milestone: 1.4.3 (was: 1.4.0)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2609
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.