Improvements to the cli getting ready for user testing. Fixes for output rendering (verbose vs normal), automatic help display, raising assertion messages properly during setup when constraints are violated, capturing output correctly from subcommands.
Generally, all things to make the cli experience "professional"
I will likely submit some more issues / patches to this ticket in prepration of a test build in the next few days.
<img alt="0001-Ticket-49544-cli-release-preperation.patch" src="/389-ds-base/issue/raw/files/fa6bdb774b723acb36c6387206f5cbb640d1ed9234790700bbc1bdd60fbb0651-0001-Ticket-49544-cli-release-preperation.patch" />
Metadata Update from @firstyear: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to review - Custom field type adjusted to None - Custom field version adjusted to None
Looks good to me, but Simon should take a look at it too
Looks good to me too! Thanks!
One small thing. Probably, it'll be better to make a docstring:
274 +def reset_get_logger(name, verbose=False): 275 + #Reset logging 275 + """Reset logging"""
Metadata Update from @spichugi: - Custom field reviewstatus adjusted to ack (was: review)
commit af8cda0 To ssh://git@pagure.io/389-ds-base.git f59c39e..af8cda0 master -> master
Applied docstrings for you @spichugi
I'll keep this open for more updates.
<img alt="0001-Ticket-49544-Double-check-pw-prompts.patch" src="/389-ds-base/issue/raw/files/cca61c45a5c0c85eecf0b7ee18a2f66d12eb27c155bd4b8cff7bb3b63aeb722b-0001-Ticket-49544-Double-check-pw-prompts.patch" />
Double check on certain password inputs.
Metadata Update from @firstyear: - Custom field reviewstatus adjusted to review (was: ack)
<img alt="0001-Ticket-49544-Double-check-pw-prompts.patch" src="/389-ds-base/issue/raw/files/5cb03041ac63c3eaf9afb38e366920afdb1df51d09a5dcc63fc18c959047f79b-0001-Ticket-49544-Double-check-pw-prompts.patch" />
Why do you need "30 +import sys" for?
Beside that - ack.
commit 743ff57413e74b49e38b96d81ced5a66e94f563f To ssh://git@pagure.io/389-ds-base.git 8ce1d38..e435e96 master -> master
@spichugi If you don't import sys sys.exit doesn't work :)
An error occured when pushing a patch, so I pushed the patch that was reviewed,
commit 45463c7 To ssh://git@pagure.io/389-ds-base.git 0f95ada..45463c7 master -> master
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2603
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.