1. 2. 3.
Metadata Update from @mreynolds: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1519406 - Custom field type adjusted to None - Custom field version adjusted to None
I addressed all the warnings, except for the ones in operation.c where we set and get op flags.
<img alt="0001-Ticket-49529-Fix-Coverity-warnings-invalid-deference.patch" src="/389-ds-base/issue/raw/files/60c50df29914ff67f8d99b1ac717941c6913bb069a6552cf7318f4c49877881d-0001-Ticket-49529-Fix-Coverity-warnings-invalid-deference.patch" />
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to review (was: None)
Just for consistency in the message,s handle_fast_add, should be:
"NULL param: pb_conn (0x%p)
So that at least we can see a consistent error. But it's a minor nit :)
get_filter_internal you check NULL and the version in one line, but the null check should raise a different log message I think because it's truly a different error?
slapi_task_log_status probably need a warning if task is NULL
Otherwise looks great mate thank you!!!
ack if you correct the above :)
Metadata Update from @firstyear: - Custom field reviewstatus adjusted to ack (was: review)
Will do!
3a161b2..7e27fac master -> master
8a4b26e..f807b9b 389-ds-base-1.3.7 -> 389-ds-base-1.3.7
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2588
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.