There's no implementation of batch argument. It is better to get rid of them.
<img alt="0001-Ticket-49479-Remove-unused-batch-argument-from-lib38.patch" src="/389-ds-base/issue/raw/files/fe51239a2bf39d507a0524c0c5abbafd6dfbf10e86398564587b595f4da84123-0001-Ticket-49479-Remove-unused-batch-argument-from-lib38.patch" />
68 69 - if self._batch: 70 - pass 71 - else: 72 - return self._instance.modify_ext_s(self._dn, [(action, key, value)], serverctrls=self._server_controls, clientctrls=self._client_controls) 73
This looks good except this bit. I think you need to keep the modify here .... else def set() won't work.
Metadata Update from @firstyear: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None
Metadata Update from @alisha17: - Custom field reviewstatus adjusted to review (was: None)
Sure I'll fix this!
Thanks, I'll look forward to the next review!
<img alt="0001-Ticket-49479-Remove-unused-batch-argument-from-lib38.patch" src="/389-ds-base/issue/raw/files/60273e83c6b64698e6494efe895e0636859a90e186cbada24d492a3934b28139-0001-Ticket-49479-Remove-unused-batch-argument-from-lib38.patch" />
Metadata Update from @alisha17: - Custom field component reset (from None) - Custom field origin reset (from None) - Custom field reviewstatus reset (from review) - Custom field type reset (from None) - Custom field version reset (from None)
@spichugi I'm happy with this, but would be good for you to check it too, just in case as it touches a few files.
Ok, lets merge it, LGTM!
commit 433f114 To ssh://git@pagure.io/389-ds-base.git 5530af5..433f114 master -> master
Metadata Update from @firstyear: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2538
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.